Add CI check against conventional commit messages#22421
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a GitHub Actions check intended to detect and prevent (or at least flag) Conventional Commits-style prefixes (e.g., feat:, fix:) in pull request commit titles, aligning commit history with Homebrew’s preferred commit message conventions.
Changes:
- Adds a new GitHub Actions workflow that scans PR commit subjects between the PR base and head SHAs.
- Fails the workflow if any commit title matches a Conventional Commits-like prefix pattern.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikeMcQuaid
approved these changes
May 26, 2026
Member
MikeMcQuaid
left a comment
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Looks good when comments addressed!
SMillerDev
force-pushed
the
feat/ci/block_conventional_commits
branch
from
c5698e8 to
aabf2cf
Compare
Since we don't use conventional commit messages, it would be good to warn people about using them
SMillerDev
force-pushed
the
feat/ci/block_conventional_commits
branch
from
cc254dd to
93412f0
Compare
Member
|
This will probably flag Dependabot though we can reintroduce the commit message config we had before: https://github.com/Homebrew/ci-orchestrator-private/blob/300aac6dd98c70b0d8f41dfcde2f99b539825a39/.github/dependabot.yml#L27-L28 |
ZhongRuoyu
reviewed
May 26, 2026
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we don't use conventional commit messages, it would be good to warn people about using them
brew lgtm(style, typechecking and tests) with your changes locally?Claude generated the whole workflow for me.